[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768066#action_12768066
 ] 

Hadoop QA commented on ZOOKEEPER-555:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12422753/ZOOKEEPER-555.patch
  against trunk revision 826787.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 28 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    -1 release audit.  The applied patch generated 182 release audit warnings 
(more than the trunk's current 181 warnings).

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/31/testReport/
Release audit warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/31/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/31/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/31/console

This message is automatically generated.

> Add stat information to GetChildrenResponse
> -------------------------------------------
>
>                 Key: ZOOKEEPER-555
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-555
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: c client, contrib-bindings, java client, server
>    Affects Versions: 3.3.0
>            Reporter: Árni Már Jónsson
>            Assignee: Árni Már Jónsson
>            Priority: Minor
>             Fix For: 3.3.0
>
>         Attachments: getchildren_stat.patch, ZOOKEEPER-555.patch, 
> ZOOKEEPER-555.patch, ZOOKEEPER-555.patch
>
>
> GetChildren() is the only non-create/delete API which does not include the 
> node stat information. I propose that the definition of GetChildren() should 
> be:
>     class GetChildrenResponse {
>         vector<ustring> children;
>         org.apache.zookeeper.data.Stat stat;
>     }
> There is a trivial fix to the server (FinalRequestProcessor.java): rsp = new 
> GetChildrenResponse(children, stat);
> And something similar to the  client library.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to