Henry Robinson commented on ZOOKEEPER-599:

Hi Flavio - 

This looks really good, thanks for taking this on. 

Can you just comment on the advantages of this approach over having the 
ResponderThread active in every LE algorithm? I see that that approach neatly 
decouples Observers from the LE algorithm (and so you wouldn't have to write 
Observer-specific code into each LE implementation); on the other hand your 
code doesn't require the extra thread. Either approach sounds ok to me, but I'd 
like to know your thoughts.


> Changes to FLE and QuorumCnxManager to support Observers
> --------------------------------------------------------
>                 Key: ZOOKEEPER-599
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-599
>             Project: Zookeeper
>          Issue Type: Improvement
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Flavio Paiva Junqueira
>             Fix For: 3.3.0
>         Attachments: ZOOKEEPER-599.patch, ZOOKEEPER-599.patch
> Observers currently can only use electionAlg 0, which is not the default, 
> supported leader implementation. This issue will fix it.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to