Gustavo Niemeyer updated ZOOKEEPER-599:

    Status: Patch Available  (was: Open)

I suppose the TODO below is referring to the "path" variable which is passed in 
as an output variable to PyArg_ParseTuple right below.  The TODO may be 
removed, since the code is right.  Code using PyArg_ParseTuple will borrow the 
reference from the calling code, since there's a stack behind the call to the 
enclosing function (pyzoo_get_children in this case) which won't go away until 
the function returns.

Index: src/contrib/zkpython/src/c/zookeeper.c
--- src/contrib/zkpython/src/c/zookeeper.c      (revision 885582)
+++ src/contrib/zkpython/src/c/zookeeper.c      (working copy)
@@ -774,8 +774,6 @@
 static PyObject *pyzoo_get_children(PyObject *self, PyObject *args)
-  // TO DO: Does Python copy the string or the reference? If it's the former
-  // we should free the String_vector
   int zkhid;
   char *path;
   PyObject *watcherfn = Py_None;

> Changes to FLE and QuorumCnxManager to support Observers
> --------------------------------------------------------
>                 Key: ZOOKEEPER-599
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-599
>             Project: Zookeeper
>          Issue Type: Improvement
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Flavio Paiva Junqueira
>             Fix For: 3.3.0
>         Attachments: ZOOKEEPER-599.patch, ZOOKEEPER-599.patch, 
> ZOOKEEPER-599.patch
> Observers currently can only use electionAlg 0, which is not the default, 
> supported leader implementation. This issue will fix it.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to