Patrick Hunt commented on ZOOKEEPER-600:

Hi Gustavo, thanks for the submit. I need to point out that we require 
submissions via patch file, details of which you can find here:
(use svn diff to create a patch, attach it to this jira using "attach file" 
link on the left hand side of this page)

The reason for this is that we need to capture your acceptance of the license 
grant to ASF. Otw we cannot
accept the patch (for legal reasons). Also our automated workflow checks 
submissions and such, it's triggered
by your attaching the file, then clicking on "submit patch". Thanks for your 

If you could attach you change as a patch file that would be great.

> TODO pondering about allocation behavior in zkpython may be removed
> -------------------------------------------------------------------
>                 Key: ZOOKEEPER-600
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-600
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.2.1
>            Reporter: Gustavo Niemeyer
>            Assignee: Gustavo Niemeyer
>            Priority: Trivial
>             Fix For: 3.3.0
> I suppose the TODO below is referring to the "path" variable which is passed 
> in as an output variable to PyArg_ParseTuple right below.  The TODO may be 
> removed, since the code is right.  Code using PyArg_ParseTuple will borrow 
> the reference from the calling code, since there's a stack behind the call to 
> the enclosing function (pyzoo_get_children in this case) which won't go away 
> until the function returns.
> Index: src/contrib/zkpython/src/c/zookeeper.c
> ===================================================================
> --- src/contrib/zkpython/src/c/zookeeper.c    (revision 885582)
> +++ src/contrib/zkpython/src/c/zookeeper.c    (working copy)
> @@ -774,8 +774,6 @@
>  static PyObject *pyzoo_get_children(PyObject *self, PyObject *args)
>  {
> -  // TO DO: Does Python copy the string or the reference? If it's the former
> -  // we should free the String_vector
>    int zkhid;
>    char *path;
>    PyObject *watcherfn = Py_None;

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to