[
https://issues.apache.org/jira/browse/ZOOKEEPER-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829283#action_12829283
]
Flavio Paiva Junqueira commented on ZOOKEEPER-524:
--------------------------------------------------
I must agree that the test awkward. Now, it takes 2 seconds on my laptop, so I
don't understand why it takes 40 seconds on your computer, Pat.
I think the idea of the test is not bad, but the implementation could be
improved. For example, we could check if the latency if at most 10% higher
after populating (10% is an arbitrary number, since it will be impossible to
get exact values).
If you guys feel strongly about removing it, I don't object and +1 it.
> DBSizeTest is not really testing anything
> -----------------------------------------
>
> Key: ZOOKEEPER-524
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-524
> Project: Zookeeper
> Issue Type: Bug
> Components: server, tests
> Reporter: Patrick Hunt
> Assignee: Benjamin Reed
> Priority: Minor
> Fix For: 3.3.0
>
>
> DBSizeTest looks like it should be testing latency, but it doesn't seem to do
> it (assert is commented out).
> We need to decide if this test should be fixed, or just dropped.
> Also note: this test takes 40seconds on my system. Way too long. Perhaps
> async create operations should be used
> to populate the database. I also noticed that data size has a big impact on
> overall test time (1k vs 5 bytes is something
> like a 2x time diff for time to run the test).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
