Patrick Hunt commented on ZOOKEEPER-678:

Hi Colin, thanks for the submission, I'm looking at it now. I was able to build 
and run it. Pretty slick - I'm navigating my znode tree just fine. Great!

A few issues/comments that I noticed, things that would have to be cleaned up:

The zip file is fine. You might just attach updates w/o the build dir, use "svn 
export" so that you don't also put the .svn dirs into the zip.

Can you add a README.txt to your "src" directory? After all your hard work it 
would be good to have some basic detail on what the project is, who wrote it 
(you) and how to build/run it. It doesn't need to be a tome, just basic 
information for someone to get up to speed quickly.

I noticed you use TableLayout, this is not compatible with Apache licensing. Is 
it possible to use something else?

See this thread for a prior discussion re tablelayout in apache that I found:

jtoaster is ok - it uses apache 2.0 license.

The icons are EPL licensed right? I think it would be a good idea to include a 
NOTICE.txt (see what I did for CDDL in the "rest" contrib). Your about box has 
this, but it would be good to have a NOTICE.txt as well.

We don't allow @author tags in the javacode, see "making changes":

Also, would you be able to use std apache license headers on the source files 
themselves? If you look at any of the other java files currently in ZooKeeper 
svn you will see what I'm talking about. You can explicitly list yourself as 
the originator/author in the README I mentioned. Would that be acceptable to 

Thanks for the submission!

> Browser application to view and edit the contents of a zookeeper instance
> -------------------------------------------------------------------------
>                 Key: ZOOKEEPER-678
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-678
>             Project: Zookeeper
>          Issue Type: New Feature
>    Affects Versions: 3.3.0
>            Reporter: Colin Goodheart-Smithe
>            Assignee: Colin Goodheart-Smithe
>             Fix For: 3.3.0
>         Attachments: ZooInspector.zip
> An application which shows a tree view of the nodes currently in a zookeeper 
> instance and allow the user to view and update the contents of the nodes as 
> well as allowing users to add and remove nodes from the tree, similar in use 
> to the Luke application in the Lucene project.
> I have a list of other features that I want to add to this application but I 
> wanted to gauge the response before I implemented them all.  I have found 
> this useful when debugging my application and thought that it may be useful 
> to others.
> I was going to submit this as a patch file but I have used some icon files 
> and one library which isn't available in the maven/ivy repositories and these 
> don't seem to work when creating a patch file using subversion.  Because of 
> this I have attached a zip containing this application to this issue.  If 
> there is a better way to submit this please let me know.
> The zip contains two directories, the src directory contains the source as it 
> would be added to the contrib folder and the build folder contains a build 
> version of the with a runnable jar.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to