Patrick Hunt commented on ZOOKEEPER-678:

Colin, it's a lot closer. :-) Great job on the updates. README is very useful.

See my attached zooInspector.sh I had to address some issues with the classpath 
(this is for dev build, donno if it's diff for other)

Notice I added an apache license header to the .sh file. You should add similar 
to any shell scripts you have (like the wind cmd file). I also had to run 
dos2unix on the .sh file (this is all in the attachment I'm adding)

Do you want your app name to match the contrib name? ZooInspector vs inspector 
(Inspector.class) I mean. Doesn't matter to me, but in terms of user 

Don't include zookeeper jar in your lib directory, for a number of reasons but 
mainly it won't be up to date.

Can you do two things? Since you are attaching a zip findbugs and the RAT tool 
won't run automatically in hudson (but they will run once this is committed). 
Can you run these two tools yourself and address any issues? (see the build.xml 
at toplevel for details on running findbugs and RAT). Sometimes these tools 
pickup useful stuff, sometimes not useful. If RAT hits on something take a look 
at a similar file in the release (.java .sh .html, etc...) and try to do 
similar. RAT basically makes sure the licensing is correct.

remove TableLayoutLicense.txt from licenses dir

Note to commiter --- be sure to mark the shell scripts as executable in SVN 
during commit.

> Browser application to view and edit the contents of a zookeeper instance
> -------------------------------------------------------------------------
>                 Key: ZOOKEEPER-678
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-678
>             Project: Zookeeper
>          Issue Type: New Feature
>    Affects Versions: 3.3.0
>            Reporter: Colin Goodheart-Smithe
>            Assignee: Colin Goodheart-Smithe
>             Fix For: 3.3.0
>         Attachments: zooInspector.sh, ZooInspector.zip, ZooInspector.zip
> An application which shows a tree view of the nodes currently in a zookeeper 
> instance and allow the user to view and update the contents of the nodes as 
> well as allowing users to add and remove nodes from the tree, similar in use 
> to the Luke application in the Lucene project.
> I have a list of other features that I want to add to this application but I 
> wanted to gauge the response before I implemented them all.  I have found 
> this useful when debugging my application and thought that it may be useful 
> to others.
> I was going to submit this as a patch file but I have used some icon files 
> and one library which isn't available in the maven/ivy repositories and these 
> don't seem to work when creating a patch file using subversion.  Because of 
> this I have attached a zip containing this application to this issue.  If 
> there is a better way to submit this please let me know.
> The zip contains two directories, the src directory contains the source as it 
> would be added to the contrib folder and the build folder contains a build 
> version of the with a runnable jar.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to