[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844968#action_12844968
 ] 

Hadoop QA commented on ZOOKEEPER-121:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12438711/ZOOKEEPER-121.patch
  against trunk revision 922459.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/21/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/21/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/21/console

This message is automatically generated.

> SyncRequestProcessor is not closing log stream during shutdown
> --------------------------------------------------------------
>
>                 Key: ZOOKEEPER-121
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, 
> ZOOKEEPER-121.patch
>
>
> The SyncRequestProcessor is not closing log stream during shutdown. 
> See FIXMEs with this ID in ClientBase.java -- I've commented out the 
> assertion for the time being (checking for logs being deleted), as part of 
> this fix re-enable these asserts and also verify tests on a Windows system.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to