Patrick Hunt commented on ZOOKEEPER-121:

I don't get this patch, more explanation is necessary. 

1) first, why are we calling append on a closed log? in what situations?

2) more importantly, this patch seems to ignore the problem, in particular it 
results in append being called, append ignores (granted warn log) the operation 
and return immediately. How is this acceptable? ie we are asked to append and 
it seems we essentially drop the request and continue on (in 
syncrequestprocessor run method loop)

> SyncRequestProcessor is not closing log stream during shutdown
> --------------------------------------------------------------
>                 Key: ZOOKEEPER-121
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 3.3.0
>         Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, 
> ZOOKEEPER-121.patch
> The SyncRequestProcessor is not closing log stream during shutdown. 
> See FIXMEs with this ID in ClientBase.java -- I've commented out the 
> assertion for the time being (checking for logs being deleted), as part of 
> this fix re-enable these asserts and also verify tests on a Windows system.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to