Patrick Hunt commented on ZOOKEEPER-725:

Henry good questions. I believe the idea here is to pull together the efforts 
(whether subtasks or links) and coordinate them.

re 1) we should fix the test pkging, also split out units vs func etc... JUnit4 
has "category" annotations. We should use these to define things like 
long/short running tests, etc... Not sure if we want to separate diff test 
types into diff directories (unit/func/perf/etc...) or use cats, or some 
combination but we need to think about that as well. src/java/test vs say 
src/java/units & src/java/func etc... Konstantin ideas for best practices here?

re 3) my expectation is we should use mockito wherever it's useful - in 
particular it seems like server side is high value. client is pretty thin, not 
sure how much can be mocked... We don't provide mocks of the ZooKeeper class 
itself, seems like tis would be useful for our users (test error conditions in 
particular). Regardless of where we use mockito we suffer from a big lack of 
"design for testability", so not only will this require big changes to the 
tests but also to the code itself. (also keep in mind we are working to 
integrate netty/avro which will each have big impact on current design)

re 4) maybe create a jira for it and link? I'd like to see perf tests run as 
part of some sort of "nightly" build. Not sure if apache hudson can do this or 
not though...  Konstantin any suggestions on this? What does MR/HDFS do for 

5) there's been some interest to move to maven, would this help/hurt us and 
should we do that beore/after doing this? is there a "best" order for doing 
these changes?

seems like we need to do incremental, and have at least 1 contributor and 1 
committer dedicated to this effort (or 2 commiters - so one can make the 
changes and the other can review/commit  them, perhaps in parallel). I would be 
willing to dedicate a chunk of my available time to this effort.

> Test organization, methodology, and infrastructure improvements 
> ----------------------------------------------------------------
>                 Key: ZOOKEEPER-725
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-725
>             Project: Zookeeper
>          Issue Type: Test
>          Components: build, tests
>            Reporter: Konstantin Boudnik
> This is an umbrella feature for a number of improvements needed to happen in 
> ZK test realm

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to