Erwin Tam commented on ZOOKEEPER-464:

Thanks Flavio.  I noticed that heap space problem intermittently too when 
running the junit tests.  It comes about  when we're reading through the entry 
logs but the format is off so the 4 byte entry length field is way too big.  We 
then try to allocate a huge buffer to read the entry from but something was 
mismatched already.  I noticed at times when running tests with small entry 
logs that the "BKLO" header doesn't get appended to it at times.  That would 
definitely screw things up when reading through it.  I'll see if I can 
reproduce this problem with the current configs in the tests and maybe exit 
more gracefully instead of allocating a huge amount of heap space for the 
buffers to read.  Obviously something must have been wrong when reading the 
entry log files.  I'm not sure why this problem only shows up a small 
percentage of the time.

Could you let me know which files still have the comments preceding new 
methods?  I thought I took this out already in the modified files but I must 
have missed some.

With regards to the documentation changes, do you generally modify the xml 
content document files, use forest to generate the html and pdf files and then 
check in all 3 changes in the jira attachment?  Or is it just the xml changes 
you submit via the jira?  Can I submit another file attachment to this same 
jira for the documentation changes?  Can you merge the changes there with the 
code changes in the already submitted patch?  Thanks!

> Need procedure to garbage collect ledgers
> -----------------------------------------
>                 Key: ZOOKEEPER-464
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-464
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: contrib-bookkeeper
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Erwin Tam
>             Fix For: 3.4.0
>         Attachments: zookeeper-464-log.txt, ZOOKEEPER-464.patch, 
> ZOOKEEPER-464.patch
> An application using BookKeeper is likely to use a large number of ledgers 
> over time. Such an application might not need all ledgers created over time 
> and might want to delete some of these ledgers to free up some space on 
> bookies. The idea of this jira is to implement a procedure that enables an 
> application to garbage-collect unwanted ledgers.
> To garbage-collect a ledger, we need to delete the ledger metadata on 
> ZooKeeper, and delete the ledger data on corresponding bookies. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to