[ https://issues.apache.org/jira/browse/ZOOKEEPER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860970#action_12860970 ]
Flavio Paiva Junqueira commented on ZOOKEEPER-464: -------------------------------------------------- Hi Erwin, Sorry about the delay to review it. I think this patch is pretty much ready to get in. I have just a couple of tiny requests: # I noticed that the two commands you modified in the documentation (bookkeeperStated.xml and bookkeeperConfig.xml) are going over the paper margin for the generated pdfs. Could you please break up the lines? # In LedgerDeleteTest, you're using "//" for multi-line comments. I believe we have been using "/**/" instead. This is just to keep it consistent with comments in other parts of the code. Otherwise, it looks good. If you fix these two things, then I think we will be able to get it in shortly after. > Need procedure to garbage collect ledgers > ----------------------------------------- > > Key: ZOOKEEPER-464 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-464 > Project: Zookeeper > Issue Type: New Feature > Components: contrib-bookkeeper > Reporter: Flavio Paiva Junqueira > Assignee: Erwin Tam > Fix For: 3.4.0 > > Attachments: zookeeper-464-log.txt, ZOOKEEPER-464.patch, > ZOOKEEPER-464.patch, ZOOKEEPER-464.patch > > > An application using BookKeeper is likely to use a large number of ledgers > over time. Such an application might not need all ledgers created over time > and might want to delete some of these ledgers to free up some space on > bookies. The idea of this jira is to implement a procedure that enables an > application to garbage-collect unwanted ledgers. > To garbage-collect a ledger, we need to delete the ledger metadata on > ZooKeeper, and delete the ledger data on corresponding bookies. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.