[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862414#action_12862414
 ] 

Benjamin Reed commented on ZOOKEEPER-690:
-----------------------------------------

i think the key fix is here:

{quote}
public void setLearnerType(LearnerType p) {
       learnerType = p;
       if (quorumPeers.containsValue(this.myid)) {
           this.quorumPeers.get(myid).type = p;
       } else {
           LOG.error("Setting LearnerType to " + p + " but " + myid 
                   + " not in QuorumPeers. ");
       }
       ...
}
{quote}

right?

the problem i see is that we are only updating the quorumPeers for the one 
peer.  the other peers are going to be thinking it is a participant.

> AsyncTestHammer test fails on hudson.
> -------------------------------------
>
>                 Key: ZOOKEEPER-690
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-690
>             Project: Zookeeper
>          Issue Type: Bug
>            Reporter: Mahadev konar
>            Assignee: Henry Robinson
>            Priority: Blocker
>             Fix For: 3.3.1, 3.4.0
>
>         Attachments: jstack-201004201053.txt, jstack-201004291409.txt, 
> nohup-201004201053.txt, nohup-201004291409.txt, 
> TEST-org.apache.zookeeper.test.AsyncHammerTest.txt, zoo.log, 
> ZOOKEEPER-690.patch
>
>
> the hudson test failed on 
> http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/2/testReport/.
>  There are huge set of cancelledkeyexceptions in the logs. Still going 
> through the logs to find out the reason for failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to