Henry Robinson commented on ZOOKEEPER-690:

Ben - 

Agreed. I see this as the same as setMyid(...) - it sets an immutable value and 
should only be called once. I'd prefer if these parameters were 'final' in 
QuorumPeer and set in the constructor, but that's not the way that 
runFromConfig (the only place outside of tests that these methods are called) 
is written. Then we could get rid of setLearnerType, for sure. 

The real error here, I think, is duplicating the learnertype between QuorumPeer 
and QuorumServer. If we are going to have the list of QuorumServers, then 
getLearnerType should lookup the learner type in the peer map. Same for the 
serverid, perhaps, and we should just save a reference to the QuorumServer that 
represents our Quorumpeer. 

> AsyncTestHammer test fails on hudson.
> -------------------------------------
>                 Key: ZOOKEEPER-690
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-690
>             Project: Zookeeper
>          Issue Type: Bug
>            Reporter: Mahadev konar
>            Assignee: Henry Robinson
>            Priority: Blocker
>             Fix For: 3.3.1, 3.4.0
>         Attachments: jstack-201004201053.txt, jstack-201004291409.txt, 
> jstack-201004291527.txt, nohup-201004201053.txt, nohup-201004291409.txt, 
> nohup-201004291527.txt, TEST-org.apache.zookeeper.test.AsyncHammerTest.txt, 
> zoo.log, ZOOKEEPER-690.patch, ZOOKEEPER-690.patch, ZOOKEEPER-690.patch
> the hudson test failed on 
> http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/2/testReport/.
>  There are huge set of cancelledkeyexceptions in the logs. Still going 
> through the logs to find out the reason for failure.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to