Hadoop QA commented on ZOOKEEPER-776:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 947063.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
Findbugs warnings: 
Console output: 

This message is automatically generated.

> API should sanity check sessionTimeout argument
> -----------------------------------------------
>                 Key: ZOOKEEPER-776
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-776
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: c client, java client
>    Affects Versions: 3.2.2, 3.3.0, 3.3.1
>         Environment: OSX 10.6.3, JVM 1.6.0-20
>            Reporter: Gregory Haskins
>            Priority: Minor
>             Fix For: 3.4.0
>         Attachments: zookeeper-776-fix.patch
> passing in a "0" sessionTimeout to ZooKeeper() constructor leads to errors in 
> subsequent operations.  It would be ideal to capture this configuration error 
> at the source by throwing something like an IllegalArgument exception when 
> the bogus sessionTimeout is specified, instead of later when it is utilized.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to