Benjamin Reed commented on ZOOKEEPER-719:

there are a couple of problems:

1) you seem to have a stray opCounterSem in PerClientBookieClient. you define 
it, but you never use it.

2) i think it might be better to use a system property to set the throttling 
rather than allow it to be dynamically changed. it simplifies the code. 
setThrottle is especially problematic since you are catching 
InterruptedException and it isn't thread safe.

> Add throttling to BookKeeper client
> -----------------------------------
>                 Key: ZOOKEEPER-719
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-719
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>    Affects Versions: 3.3.0
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Flavio Paiva Junqueira
>             Fix For: 3.4.0
>         Attachments: ZOOKEEPER-719.patch, ZOOKEEPER-719.patch
> Add throttling to client to control the rate of operations to bookies. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to