[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873386#action_12873386
 ] 

Flavio Paiva Junqueira commented on ZOOKEEPER-719:
--------------------------------------------------

Thanks for the comments, Ben. I see three options to set the throttling 
threshold:

# Use a configuration file to set the parameter value. Unfortunately, there are 
a couple of issues to this option. First, we currently don't have a config file 
on the client side, and I'm not sure if one variable would justify setting it 
up. Second, I'm not convinced that it is a good idea to have config files on 
the client side. It is nice to instantiate a BookKeeper object without having 
to bother about config files (on the client side);
# Add an input variable to BookKeeper constructors or to 
createLedger/openLedger calls. This one sounds like a bad option to me because 
I don't think it will be used often and it is not related to the corresponding 
operations; 
# Use set/get calls to change the threshold value. This is what I used with 
this patch.

A fourth option is to have an environment variable, but this is similar to 
having a config file, so I'm not sure there is any great advantage.

Any thoughts?

> Add throttling to BookKeeper client
> -----------------------------------
>
>                 Key: ZOOKEEPER-719
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-719
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: contrib-bookkeeper
>    Affects Versions: 3.3.0
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Flavio Paiva Junqueira
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-719.patch, ZOOKEEPER-719.patch
>
>
> Add throttling to client to control the rate of operations to bookies. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to