[ https://issues.apache.org/jira/browse/ZOOKEEPER-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897411#action_12897411 ]
Thomas Koch commented on ZOOKEEPER-837: --------------------------------------- I've managed to make ClientCnxn independent from ZooKeeper. Could you give me please a first review of the changes from this branch? Thank you! http://github.com/thkoch2001/zookeeper/tree/ZOOKEEPER-837_uncycle_cxcn_from_zk > cyclic dependency ClientCnxn, ZooKeeper > --------------------------------------- > > Key: ZOOKEEPER-837 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-837 > Project: Zookeeper > Issue Type: Sub-task > Affects Versions: 3.3.1 > Reporter: Patrick Datko > > ZooKeeper instantiates ClientCnxn in its ctor with this and therefor builds a > cyclic dependency graph between both objects. This means, you can't have the > one without the other. So why did you bother do make them to separate classes > in the first place? > ClientCnxn accesses ZooKeeper.state. State should rather be a property of > ClientCnxn. And ClientCnxn accesses zooKeeper.get???Watches() in its method > primeConnection(). I've not yet checked, how this dependency should be > resolved better. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.