Thomas Koch commented on ZOOKEEPER-823:

Hi Ivan,

thank you for looking over the patch. I agree with all your comments but the 
last one on src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO:L110. Yes, 
the separate try-catches seem necessary to me.
I've added a link to issue ZOOKEEPER-702 about the incompatibility.
In general, it's easier to review patches that do small incremental changes. So 
I'd propose that you open separate jira issues for your observations so that we 
can work on them after this patch has been committed.
I already opened ZOOKEEPER-835 as an umbrella issue for several clean ups in 
the ZK java client code. Your issues would fit in there.

> update ZooKeeper java client to optionally use Netty for connections
> --------------------------------------------------------------------
>                 Key: ZOOKEEPER-823
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-823
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: java client
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.4.0
>         Attachments: ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, 
> ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, ZOOKEEPER-823.patch
> This jira will port the client side connection code to use netty rather than 
> direct nio.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to