Thomas Koch updated ZOOKEEPER-823:

    Attachment: ZOOKEEPER-823.patch

I changed the following things:

- call the correct cleanup() method. I f..ed up to refactor the call hierarchy
- combine doReads() and doWrites() again into doIO() in NIO as it was before
- all access to selector is synchronized on ClientCnxnSocket

I'm having problems to run the testsuite and believe that I'm somehow bitten by 
ZOOKEEPER-126. Some Tests just block and when I debug them, they always wait 
indefinitely on packet.wait().

Something like the following helped, however with every different attempt to 
solve ZOOKEEPER-126 other tests failed respectively blocked.

@@ -1088,6 +1088,10 @@ public class ClientCnxn {
         ReplyHeader r = new ReplyHeader();
         Packet packet = queuePacket(h, r, request, response, null, null, null,
                 null, watchRegistration);
+        if(h.getType() == ZooDefs.OpCode.closeSession){
+            Thread.sleep((long) (sessionTimeout*1.1));
+            return r;
+        }
         synchronized (packet) {
             while (!packet.finished) {

My tests still run now with the above code. Some take 10 minutes and more.

I also had to reduce the number of hammerthreads in 
org.apache.zookeeper.test.AsyncHammerTest to 10 to make it work.

I'm running openjdk 
java version "1.6.0_18"
OpenJDK Runtime Environment (IcedTea6 1.8.1) (6b18-1.8.1-1)
OpenJDK 64-Bit Server VM (build 16.0-b13, mixed mode)

> update ZooKeeper java client to optionally use Netty for connections
> --------------------------------------------------------------------
>                 Key: ZOOKEEPER-823
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-823
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: java client
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.4.0
>         Attachments: ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, 
> ZOOKEEPER-823.patch, ZOOKEEPER-823.patch
> This jira will port the client side connection code to use netty rather than 
> direct nio.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to