[
https://issues.apache.org/jira/browse/ZOOKEEPER-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923779#action_12923779
]
Patrick Hunt commented on ZOOKEEPER-909:
----------------------------------------
I ran the tests on my own test harness and they passed. I've started to review,
here's what I noticed so far:
Might want to fix these:
Warnings:
[javac]
/home/phunt/dev/workspace/gitzk/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java:37:
warning: [deprecation] org.jboss.netty.channel.ChannelPipelineCoverage in
org.jboss.netty.channel has been deprecated
[javac] import org.jboss.netty.channel.ChannelPipelineCoverage;
[javac] ^
[javac]
/home/phunt/dev/workspace/gitzk/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java:64:
warning: [deprecation] org.jboss.netty.channel.ChannelPipelineCoverage in
org.jboss.netty.channel has been deprecated
[javac] @ChannelPipelineCoverage("all")
[javac] ^
the added (new) files are missing a license header
> Extract NIO specific code from ClientCnxn
> -----------------------------------------
>
> Key: ZOOKEEPER-909
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-909
> Project: Zookeeper
> Issue Type: Sub-task
> Components: java client
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-909.patch, ZOOKEEPER-909.patch
>
>
> This patch is mostly the same patch as my last one for ZOOKEEPER-823 minus
> everything Netty related. This means this patch only extract all NIO specific
> code in the class ClientCnxnSocketNIO which extends ClientCnxnSocket.
> I've redone this patch from current trunk step by step now and couldn't find
> any logical error. I've already done a couple of successful test runs and
> will continue to do so this night.
> It would be nice, if we could apply this patch as soon as possible to trunk.
> This allows us to continue to work on the netty integration without blocking
> the ClientCnxn class. Adding Netty after this patch should be only a matter
> of adding the ClientCnxnSocketNetty class with the appropriate test cases.
> You could help me by reviewing the patch and by running it on whatever test
> server you have available. Please send me any complete failure log you should
> encounter to thomas at koch point ro. Thx!
> Update: Until now, I've collected 8 successful builds in a row!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
