Patrick Hunt commented on ZOOKEEPER-909:

Thomas, I assigned the jira to you because you're doing most/all the work to 
get this done, not as a work token. I believe you should get the credit when 
this patch gets committed.

Typically we use assignment (esp when a patch gets committed) to credit the 
author - that's one of the criteria we monitor when deciding on new committers 
(number and quality of patches, testing, conformance to community style 
guidelinesl, etc...)

Feel free to reassign this to yourself (please).

> Extract NIO specific code from ClientCnxn
> -----------------------------------------
>                 Key: ZOOKEEPER-909
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-909
>             Project: Zookeeper
>          Issue Type: Sub-task
>          Components: java client
>            Reporter: Thomas Koch
>            Assignee: Patrick Hunt
>             Fix For: 3.4.0
>         Attachments: ZOOKEEPER-909.patch, ZOOKEEPER-909.patch, 
> ZOOKEEPER-909.patch
> This patch is mostly the same patch as my last one for ZOOKEEPER-823 minus 
> everything Netty related. This means this patch only extract all NIO specific 
> code in the class ClientCnxnSocketNIO which extends ClientCnxnSocket.
> I've redone this patch from current trunk step by step now and couldn't find 
> any logical error. I've already done a couple of successful test runs and 
> will continue to do so this night.
> It would be nice, if we could apply this patch as soon as possible to trunk. 
> This allows us to continue to work on the netty integration without blocking 
> the ClientCnxn class. Adding Netty after this patch should be only a matter 
> of adding the ClientCnxnSocketNetty class with the appropriate test cases.
> You could help me by reviewing the patch and by running it on whatever test 
> server you have available. Please send me any complete failure log you should 
> encounter to thomas at koch point ro. Thx!
> Update: Until now, I've collected 8 successful builds in a row!

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to