Patrick Hunt commented on ZOOKEEPER-912:

Hi Anthony, I realized in the shower this morning, by "Zookeeper" did you mean 
"ZooKeeper.java"? My bad.

I looked at this class again and it does have logging at other levels than just 
info. Really it should have trace level logs for each of the api entry points. 
I'm concerned about pushing down the info level logs you highlighted though due 
to a couple factors; 1) in our experience those msgs are very useful to 
understand the runtime state of the client, 2) many users don't run in 
production at trace (and some don't want to run in debug).

What's your rule of thumb for what should be logged at the various levels?

> ZooKeeper client logs trace and debug messages at level INFO
> ------------------------------------------------------------
>                 Key: ZOOKEEPER-912
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-912
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.3.1
>            Reporter: Anthony Urso
>            Assignee: Anthony Urso
>            Priority: Minor
>             Fix For: 3.4.0
>         Attachments: zk-loglevel.patch
> ZK logs a lot of uninformative trace and debug messages to level INFO.  This 
> fuzzes up everything and makes it easy to miss useful log info. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to