Patrick Hunt commented on ZOOKEEPER-912:

John could you give some examples of the log messages (ones actually output to 
the log) that you thought were excessive? (did you mean client or server? 
both?) It might help to frame the conversation. We might be able to address 
some of the more egregious ones.

Here's a client session (default log4j.properties) where I created a client, 
ran a few commands, then quit (cli shell):

2010-11-04 17:16:21,319 - INFO  [main:zookee...@373] - Initiating client 
connection, connectString= sessionTimeout=30000 
2010-11-04 17:16:21,347 - INFO  [main-SendThread():clientcnxn$sendthr...@1000] 
- Opening socket connection to server localhost/
2010-11-04 17:16:21,392 - INFO  
[main-SendThread(localhost:2181):clientcnxn$sendthr...@908] - Socket connection 
established to localhost/, initiating session
2010-11-04 17:16:21,486 - INFO  
[main-SendThread(localhost:2181):clientcnxn$sendthr...@701] - Session 
establishment complete on server localhost/, sessionid = 
0x12c1963f8210000, negotiated timeout = 30000

then nothing until I quit

2010-11-04 17:16:49,401 - INFO  [main:zookee...@538] - Session: 
0x12c1963f8210000 closed

So the _entirety_ of the logging today is just 4 messages for the client 
establishment, one for closing the client. During the time that the client has 
an active session established there are no messages output. I don't see that as 
excessive personally, but others might not think the same. In my experience 
these are some very important messages when helping postmortem production 

I could see where we might drop msgs 1-3 to debug level (keep 4, the 
"established" msg), as long as we highlight connection attempts that fail. 
Having detail about the sessionid and negotiated timeout is pretty critical 
though, from an informational perspective.

> ZooKeeper client logs trace and debug messages at level INFO
> ------------------------------------------------------------
>                 Key: ZOOKEEPER-912
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-912
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.3.1
>            Reporter: Anthony Urso
>            Assignee: Anthony Urso
>            Priority: Minor
>             Fix For: 3.4.0
>         Attachments: zk-loglevel.patch
> ZK logs a lot of uninformative trace and debug messages to level INFO.  This 
> fuzzes up everything and makes it easy to miss useful log info. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

Reply via email to