[ https://issues.apache.org/jira/browse/ZOOKEEPER-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927036#action_12927036 ]
Patrick Hunt commented on ZOOKEEPER-850: ---------------------------------------- Hi Olaf, thanks for the patch. A couple questions/comments: 1) can you create this patch against trunk? We only put bug fixes into the fix releases, so this would be slated for 3.4.0 release (current trunk). 2) do any of the shell scripts need to be updated? (bin directory) 3) I see references to log4j in the build.xml file(s). Do any of these need to be upated? It would be good if you could build a release (ant tar) and verify that the built archive can run zk server/client via the bin scripts. 4) It looks like the documentation also needs to be updated, do a "egrep -Ri log4j src/docs/src/documentation/ log4j" from the toplevel. We should at least update the existing docs, also it would be helpful to include addl information to help both users and developers make the switch. 5) we typically create "release notes" for a release, it would be good to document in this JIRA (the rel notes section) any details we should include in the release notes documentation that goes along with the release. Some short statement detailing the change an any impact (you've given some detail in the comments, basically wrapping it up into something short/simple for users to follow during upgrade). Thanks! > Switch from log4j to slf4j > -------------------------- > > Key: ZOOKEEPER-850 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-850 > Project: Zookeeper > Issue Type: Improvement > Components: java client > Affects Versions: 3.3.1 > Reporter: Olaf Krische > Assignee: Olaf Krische > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-3.3.1-log4j-slf4j-20101031.patch.bz2 > > > Hello, > i would like to see slf4j integrated into the zookeeper instead of relying > explicitly on log4j. > slf4j is an abstract logging framework. There are adapters from slf4j to many > logger implementations, one of them is log4j. > The decision which log engine to use i dont like to make so early. > This would help me to embed zookeeper in my own applications (which use a > different logger implemenation, but slf4j is the basis) > What do you think? > (as i can see, those slf4j request flood all other projects on apache as well > :-) > Maybe for 3.4 or 4.0? > I can offer a patchset, i have experience in such an migration already. :-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.