[ https://issues.apache.org/jira/browse/ZOOKEEPER-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930267#action_12930267 ]
Hadoop QA commented on ZOOKEEPER-850: ------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459170/ZOOKEEPER-850.patch against trunk revision 1033155. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 249 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/14//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/14//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/14//console This message is automatically generated. > Switch from log4j to slf4j > -------------------------- > > Key: ZOOKEEPER-850 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-850 > Project: Zookeeper > Issue Type: Improvement > Components: java client > Affects Versions: 3.3.1 > Reporter: Olaf Krische > Assignee: Olaf Krische > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-3.3.1-log4j-slf4j-20101031.patch.bz2, > ZOOKEEPER-3.4.0-log4j-slf4j-20101102.patch.bz2, ZOOKEEPER-850.patch > > > Hello, > i would like to see slf4j integrated into the zookeeper instead of relying > explicitly on log4j. > slf4j is an abstract logging framework. There are adapters from slf4j to many > logger implementations, one of them is log4j. > The decision which log engine to use i dont like to make so early. > This would help me to embed zookeeper in my own applications (which use a > different logger implemenation, but slf4j is the basis) > What do you think? > (as i can see, those slf4j request flood all other projects on apache as well > :-) > Maybe for 3.4 or 4.0? > I can offer a patchset, i have experience in such an migration already. :-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.