[ https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933918#action_12933918 ]
Hadoop QA commented on ZOOKEEPER-836: ------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12460034/ZOOKEEPER-836.patch against trunk revision 1036967. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/38//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/38//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/38//console This message is automatically generated. > hostlist as string > ------------------ > > Key: ZOOKEEPER-836 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-836 > Project: Zookeeper > Issue Type: Sub-task > Components: java client > Affects Versions: 3.3.1 > Reporter: Patrick Datko > Assignee: Thomas Koch > Attachments: ZOOKEEPER-836.patch > > > The hostlist is parsed in the ctor of ClientCnxn. This violates the rule of > not doing (too much) work in a ctor. Instead the ClientCnxn should receive an > object of class "HostSet". HostSet could then be instantiated e.g. with a > comma separated string. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.