[
https://issues.apache.org/jira/browse/ZOOKEEPER-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934591#action_12934591
]
Thomas Koch commented on ZOOKEEPER-836:
---------------------------------------
Hi Benjamin,
this kind of HostSet class you mention could still be introduced on top of this
issue. I'd like in this case to do this in a separate issue where we'd also
discuss the design. In this issue I just wanted to get rid of the connectString
parsing in ClientCnxn and prepare ClientCnxn to have the chrootPath moved out
of it.
If you could commit this patch as it, I could continue with the patches I've in
my pipe.
> hostlist as string
> ------------------
>
> Key: ZOOKEEPER-836
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-836
> Project: Zookeeper
> Issue Type: Sub-task
> Components: java client
> Affects Versions: 3.3.1
> Reporter: Patrick Datko
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-836.patch
>
>
> The hostlist is parsed in the ctor of ClientCnxn. This violates the rule of
> not doing (too much) work in a ctor. Instead the ClientCnxn should receive an
> object of class "HostSet". HostSet could then be instantiated e.g. with a
> comma separated string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
