On 27 September 2010 19:33, Laurence Rowe <l...@lrowe.co.uk> wrote: > On 25 September 2010 16:26, Charlie Clark > <charlie.cl...@clark-consulting.eu> wrote: >> Am 24.09.2010, 00:18 Uhr, schrieb Laurence Rowe <l...@lrowe.co.uk>: >> >>> If there are no objections I shall merge the changes back to trunk. >> >> +1 from me. Please update changes.txt >> >> From your original post: >> >> * I currently adapt based on (IContentish, IWorkflowDefinition) should >> this be made more general, i.e. (Interface, IWorkflowDefinition)? Does >> anyone workflow anything that is not IContentish? >> >> Shouldn't only IWorkflowAware be adapted? > > I've changed it to adapt (IWorflowAware, IWorkflowDefinition) now. > I've also made a change so that objects are possibly adapted to > IWorkflowAware before calling notifyWorkflowCreated so this may be > implemented as an adapter instead of a mixin. > >> * Is deprecating getStatusOf, setStatusOf, getHistoryOf desirable? I'm not >> sure it would serve any particular purpose. >> >> Looking at the implementation the question I would ask myself is, what are >> the alternatives? In general I'd agree with yuppie on less tool methods >> and more adapters but not with the current spelling for multiadapters. > > I don't think it really serves any purpose at this time. I'll merge to > trunk later this week assuming no objections.
Merged in 117773 Laurence _______________________________________________ Zope-CMF maillist - Zope-CMF@zope.org https://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
