Stephan Richter wrote:
On Friday 09 November 2007, Philipp von Weitershausen wrote:
Modified: zope.app.securitypolicy/trunk/setup.py
===================================================================
--- zope.app.securitypolicy/trunk/setup.py      2007-11-09 13:08:59 UTC
(rev 81634) +++ zope.app.securitypolicy/trunk/setup.py      2007-11-09
14:52:52 UTC (rev 81635) @@ -58,7 +58,7 @@
                       'zope.configuration',
                       'zope.exceptions',
                       'zope.i18n',
-                      'zope.i18nmessageid',
+                      'zope.i18nmessageid >= 3.4.2',
                       'zope.interface',
                       'zope.location',
                       'zope.schema',


Please let's stop putting versions into setup.py. This is a really bad idea, since it will make it very hard to work with in different project with different version requirements.

Only the '==' qualifier in setup.py is a bad idea because it locks you down. Other qualifiers are actually quite necessary sometimes.

In this case, for instance, we *need* the >= qualifier because zope.app.securitypolicy won't work with just any version of zope.i18nmessageid. It needs at least version 3.4.2 because that one introduced the ZopeMessageFactory object which zope.app.securitypolicy wants to import.

Such considerations must always be made when you add a feature to package A, and then use that new feature in package B. Package B must then require at least that new version of package A.
_______________________________________________
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )

Reply via email to