Hi Baiju If this whitespace fix is based on the current style guide, I think the guide needs to be fixed. I find the fixed version much less readable. A function that takes this many arguments should have an exception to the PEP 8 rule of no whitespace around the equals sign used for keyword arguments. I *think* a reasonable rule is that if you split the call over multiple lines with one argument per line, you should add single spaces before and after the equals sign. What does anyone else think?
- Jacob Baiju M wrote: > Log message for revision 98773: > Whitespace fixes > > > Changed: > U zope.annotation/trunk/setup.py > > -=- > Modified: zope.annotation/trunk/setup.py > =================================================================== > --- zope.annotation/trunk/setup.py 2009-04-01 21:02:33 UTC (rev 98772) > +++ zope.annotation/trunk/setup.py 2009-04-01 21:13:34 UTC (rev 98773) > @@ -23,14 +23,14 @@ > return open(os.path.join(os.path.dirname(__file__), *rnames)).read() > > setup( > - name = 'zope.annotation', > - version = '3.5.0dev', > - url = 'http://pypi.python.org/pypi/zope.annotation', > - license = 'ZPL 2.1', > - description = 'Object annotation mechanism', > - author = 'Zope Corporation and Contributors', > - author_email = 'zope-dev@zope.org', > - classifiers = [ > + name='zope.annotation', > + version='3.5.0dev', > + url='http://pypi.python.org/pypi/zope.annotation', > + license='ZPL 2.1', > + description='Object annotation mechanism', > + author='Zope Corporation and Contributors', > + author_email='zope-dev@zope.org', > + classifiers=[ > 'Development Status :: 5 - Production/Stable', > 'Intended Audience :: Developers', > 'License :: OSI Approved :: Zope Public License', > @@ -40,23 +40,23 @@ > 'Topic :: Internet :: WWW/HTTP', > 'Topic :: Software Development', > ], > - long_description = \ > + long_description= \ > read('src', 'zope', 'annotation', 'README.txt') > + '\n\n' + > read('CHANGES.txt'), > - packages = find_packages('src'), > - package_dir = {'': 'src'}, > - namespace_packages = ['zope',], > - install_requires = ['setuptools', > - 'zope.interface', > - 'zope.component', > - 'zope.location', > - 'zope.proxy', > - ], > - extras_require = dict( > - test = ['zope.testing', > - 'ZODB3'], > + packages=find_packages('src'), > + package_dir={'': 'src'}, > + namespace_packages=['zope',], > + install_requires=['setuptools', > + 'zope.interface', > + 'zope.component', > + 'zope.location', > + 'zope.proxy', > + ], > + extras_require=dict( > + test=['zope.testing', > + 'ZODB3'], > ), > - include_package_data = True, > - zip_safe = False, > + include_package_data=True, > + zip_safe=False, > ) > > _______________________________________________ > Checkins mailing list > check...@zope.org > http://mail.zope.org/mailman/listinfo/checkins > _______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
