Previously Jens Vagelpohl wrote:
> - - IMutablePropertiesPlugin.getPropertiesForUser deviates from the  
> original contract in IPropertiesPlugin.getPropertiesForUser and  
> returns a property sheet object instead of a mapping. IMHO it should  
> return a mapping.

It has to return an object so it can persist property changes. 

> - - IPropertiesPlugin.setPropertiesForUser claims to only accept a  
> propertysheet object, but it would probably work fine with a simple  
> mapping (eyeballing the implementation in the  
> ZODBMutablePropertyProvider class). The contract could be changed to  
> accept mappings.

Indeed, I'll update the contract to that effect.

> - - setting properties on a user will magically turn around and persist  
> the change. This would be the first user folder I have seen where  
> this happens. Personally, I'm a bit uncomfortable with this magic.

setProperty on GRUFUser will persist the change as well.

Wichert.

-- 
Wichert Akkerman <[EMAIL PROTECTED]>    It is simple to make things.
http://www.wiggy.net/                   It is hard to make things simple.
_______________________________________________
Zope-PAS mailing list
Zope-PAS@zope.org
http://mail.zope.org/mailman/listinfo/zope-pas

Reply via email to