Review: Needs Fixing
- There seems to be a merge conflict.
- The stream stored in the state must be deleted using the streamReleaser
- The lErrorMessage stream is passed as parameter but the errors only take one
parameter.
- The LoadProperties are not used anywhere
- The following can be simplified
if(getline(*state->theStream, streamLine))
{
do
{
STACK_PUSH(GENV_ITEMFACTORY->createString(result, streamLine), state);
}
while (getline(*state->theStream, streamLine));
}
else
STACK_PUSH(false, state);
=>
while (getline(*state->theStream, streamLine))
{
STACK_PUSH(GENV_ITEMFACTORY->createString(result, streamLine), state);
}
--
https://code.launchpad.net/~zorba-coders/zorba/fn_envvars/+merge/88143
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp
