Review: Needs Fixing

1. To maintain ABI compatibility, you must only add new virtual functions to 
the end of public classes.

2. I don't like that this mechanism is so different to the way you block 
non-internal modules (using a URIMapper with DENY_ACCESS). While it would be a 
bit less efficient, it would be more consistent to call 
static_context::resolve_uri() at translator.cpp line 2840 solely for the 
purpose of seeing if zerr::ZXQP0029_URI_ACCESS_DENIED is thrown.
Your team Zorba Coders is subscribed to branch lp:zorba.

Mailing list:
Post to     :
Unsubscribe :
More help   :

Reply via email to