Review: Needs Fixing

- Why is the following change necessary?

-      -q "import module namespace file = 'http://expath.org/ns/file'; 
file:exists( 'a non existant file' )"
+      -q "import module namespace file = 'http://expath.org/ns/file'; import 
module namespace x = 'http://www.zorba-xquery.com/modules/xml'; file:exists( 'a 
non existant file' )"

- s/ Canonical XMl/ Canonical XML/

- Which options are enabled by default?

- The example doesn't mention that the options are in a namespace? According to 
the schema they should be. According to the implementation, the namespace isn't 
considered.

- There should be a private canonicalize function that does the schema 
validation if the input is not validated similarly to most other modules.

-- 
https://code.launchpad.net/~zorba-coders/zorba/canonicalize-core-fixed/+merge/142394
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to     : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Reply via email to