Review: Needs Information

Looks good to me. Only two issues.

- The thing with the probe iterators is that there are additional functions 
called probe-*-skip that allow
you to skip explicitly. However, subsequence is not rewritten into these 
functions. We will need to override the skip function in all the probe 
iterators (similar to count) such that subsequence(probe-*) will be executed 
efficiently. We can do this is a second step though. I'll create a follow up 
story for this.

- In ZorbaCollectionIterator::initCollection lines 307 and 326, you eventually 
add skipCount twice. Something smells spooky here.

Your team Zorba Coders is subscribed to branch lp:zorba.

Mailing list:
Post to     :
Unsubscribe :
More help   :

Reply via email to