I would also like to endorse putting this module into AOLserver CVS.  I just
tried it out to diagnose a problem page and instantly determined that one
proc call was responsible for 96% of the page building time.  Thank you very
much Eric!  It would have been a lot more painful to track that down with
time {} statements.

The module could use some cleanup, for example:
 - I would rename it nstclprof, and maybe rename some of the API functions
to be more AOLserver-ish (ns_)
 - The included .tcl files should probably be converted to .adp files, and
it would be nice to add some extra explanatory text to them, and maybe add
column sorting like in the _stats package.
 - It requires a code change to work with AOLserver 4, changing
Ns_TclGetConn(NULL) to Ns_TclGetConn(interp)
 - Not virtual-server config ready
 - It can crash AOLserver if you test a large number of requests in a short
time, haven't debugged this yet.  Also seems to spin if you click on a
request that has been flushed.

The source is available at http://www.piskorski.com/acs/tclprof-lorenzo-1.0.tgz

Jamie


On Sat, 10 Jul 2004 08:17:02 -0400, Andrew Piskorski <[EMAIL PROTECTED]> wrote:

>Back in 2002, Eric Lorenzo wrote an AOLserver module he called
>"tclprof" to do profiling of Tcl code, and released it under the GPL.
>I used it a bit back then, as well as nsprofile.  See more info and an
>initial review here:
>
>  http://openacs.org/forums/message-view?message_id=32971
>
>Lately Dave Bauer has tried it out a bit with AOLserver 4.x.  Also,
>Eric L. basically says that he never did any further work on tclprof,
>and isn't likely to in the future either.
>
>I think we should put tclprof into AOLserver CVS.  Both Dave and I
>have a copy of the code, where should we send it, or what else should
>we do to get it into CVS?
>
>As I mentioned in my old initial review above, tclprof appears to be
>more sophisticated than nsprofile, and the two are definitely quite
>different.  It would of course be better to have one really good
>profiler rather than several mediocre ones, but I think the first step
>is just to get the tclprof code into CVS so it won't get lost (it
>already almost did), and so that anyone can easily compare the tclprof
>and nsprofile code, figure out how to improve one or the other, etc.
>
>--
>Andrew Piskorski <[EMAIL PROTECTED]>
>http://www.piskorski.com/
>
>
>--
>AOLserver - http://www.aolserver.com/
>
>To Remove yourself from this list, simply send an email to
<[EMAIL PROTECTED]> with the
>body of "SIGNOFF AOLSERVER" in the email message. You can leave the
Subject: field of your email blank.


--
AOLserver - http://www.aolserver.com/

To Remove yourself from this list, simply send an email to <[EMAIL PROTECTED]> with the
body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject: field of 
your email blank.

Reply via email to