> On Jun 24, 2021, at 10:11 AM, Emmanuel Lécharny <elecha...@gmail.com> wrote:
> 
> 
> On 24/06/2021 15:57, Shawn McKinney wrote:
>> interfaces should describe a type and hence have methods
> 
> Whatever.
> 
> There is a suppressions.xml file in src/checkstyle that list the classes that 
> are to be ignred. here is its content:
> 

The answer to your earlier question, ‘yes’, it extends Control:

```
public interface RelaxControl extends Control
{
  String OID = "1.3.6.1.4.1.4203.666.5.12";

  String getOID();
}
```

As you can see, I worked around the check styles problem by adding a trivial 
method, getOID to the interface.

So, I’ll not add it to the suppressions list, as most of its checks are fine.  
But, thanks for letting me know. (I knew there must be one somewhere)


> <suppressions>
>    <!-- Control inferfaces that don't declare any new method -->
>    <suppress files="org.apache.directory.api.ldap.extras.extended" 
> checks="InterfaceIsType" />
>    <suppress files="org.apache.directory.api.ldap.extras.controls.ad" 
> checks="InterfaceIsType" />
>    <suppress 
> files="org.apache.directory.api.ldap.extras.controls.permissiveModify" 
> checks="InterfaceIsType" />
>    <suppress files="org.apache.directory.api.ldap.extras.controls.ppolicy" 
> checks="InterfaceIsType" />
>    <suppress 
> files="org.apache.directory.api.ldap.extras.controls.changeNotifications" 
> checks="InterfaceIsType" />
> </suppressions>
> 
> Add the RelaxControl in this file :
> 
> <suppressions>
>    <!-- Control inferfaces that don't declare any new method -->
>    <suppress files="org.apache.directory.api.ldap.extras.extended" 
> checks="InterfaceIsType" />
>    <suppress files="org.apache.directory.api.ldap.extras.controls.ad" 
> checks="InterfaceIsType" />
>    <suppress files="org.apache.directory.api.ldap.extras.controls.relax" 
> checks="InterfaceIsType" />
> ...
> </suppressions>


---------------------------------------------------------------------
To unsubscribe, e-mail: api-unsubscr...@directory.apache.org
For additional commands, e-mail: api-h...@directory.apache.org

Reply via email to