----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3410/#review11470 -----------------------------------------------------------
/team/group/media_formats-reviewed/addons/chan_ooh323.c <https://reviewboard.asterisk.org/r/3410/#comment21164> Does ast_best_codec now accept the pointer by ref (this just stood out as it didn't change)? I looked in "reviewed" branch and didn't notice that it does. /team/group/media_formats-reviewed/addons/chan_ooh323.c <https://reviewboard.asterisk.org/r/3410/#comment21165> Remove commented code? /team/group/media_formats-reviewed/addons/chan_ooh323.c <https://reviewboard.asterisk.org/r/3410/#comment21166> gCap and ooh323_tech.capabilities don't seemed to be released on subsequent load errors (several paths below these). /team/group/media_formats-reviewed/addons/chan_ooh323.c <https://reviewboard.asterisk.org/r/3410/#comment21167> more commented code. /team/group/media_formats-reviewed/channels/chan_console.c <https://reviewboard.asterisk.org/r/3410/#comment21168> console_tech.capabilities needs to be released on any subsequent module load errors (some below the highlighted code). /team/group/media_formats-reviewed/channels/chan_multicast_rtp.c <https://reviewboard.asterisk.org/r/3410/#comment21169> multicast_rtp_tech.capabilities needs to be unref'ed on module decline if the channel fails to register. - Kevin Harwell On March 31, 2014, 9:52 a.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3410/ > ----------------------------------------------------------- > > (Updated March 31, 2014, 9:52 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This change moves the chan_multicast_rtp, chan_console, app_jack, and > chan_ooh323 modules over to media formats. > > > Diffs > ----- > > /team/group/media_formats-reviewed/include/asterisk/format_cache.h 411016 > /team/group/media_formats-reviewed/channels/chan_phone.c 411573 > /team/group/media_formats-reviewed/channels/chan_multicast_rtp.c 409286 > /team/group/media_formats-reviewed/channels/chan_console.c 409286 > /team/group/media_formats-reviewed/apps/app_jack.c 409286 > /team/group/media_formats-reviewed/addons/ooh323cDriver.c 409286 > /team/group/media_formats-reviewed/addons/ooh323cDriver.h 409286 > /team/group/media_formats-reviewed/addons/format_mp3.c 409286 > /team/group/media_formats-reviewed/addons/chan_ooh323.c 409286 > /team/group/media_formats-reviewed/addons/chan_ooh323.h 409286 > /team/group/media_formats-reviewed/addons/chan_mobile.c 409286 > > Diff: https://reviewboard.asterisk.org/r/3410/diff/ > > > Testing > ------- > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
