> On April 1, 2014, 9:15 p.m., Kevin Harwell wrote: > > /team/group/media_formats-reviewed/addons/chan_ooh323.c, lines 1556-1558 > > <https://reviewboard.asterisk.org/r/3410/diff/1/?file=56941#file56941line1556> > > > > Remove commented code?
I've changed these to BUGBUGs. > On April 1, 2014, 9:15 p.m., Kevin Harwell wrote: > > /team/group/media_formats-reviewed/addons/chan_ooh323.c, lines 390-391 > > <https://reviewboard.asterisk.org/r/3410/diff/1/?file=56941#file56941line390> > > > > Does ast_best_codec now accept the pointer by ref (this just stood out > > as it didn't change)? I looked in "reviewed" branch and didn't notice that > > it does. Sure does, although the core channel file has yet to be changed so it remains to be seen what it'll be like in the end (ast_best_codec is ... interesting). - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3410/#review11470 ----------------------------------------------------------- On March 31, 2014, 2:52 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3410/ > ----------------------------------------------------------- > > (Updated March 31, 2014, 2:52 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This change moves the chan_multicast_rtp, chan_console, app_jack, and > chan_ooh323 modules over to media formats. > > > Diffs > ----- > > /team/group/media_formats-reviewed/include/asterisk/format_cache.h 411016 > /team/group/media_formats-reviewed/channels/chan_phone.c 411573 > /team/group/media_formats-reviewed/channels/chan_multicast_rtp.c 409286 > /team/group/media_formats-reviewed/channels/chan_console.c 409286 > /team/group/media_formats-reviewed/apps/app_jack.c 409286 > /team/group/media_formats-reviewed/addons/ooh323cDriver.c 409286 > /team/group/media_formats-reviewed/addons/ooh323cDriver.h 409286 > /team/group/media_formats-reviewed/addons/format_mp3.c 409286 > /team/group/media_formats-reviewed/addons/chan_ooh323.c 409286 > /team/group/media_formats-reviewed/addons/chan_ooh323.h 409286 > /team/group/media_formats-reviewed/addons/chan_mobile.c 409286 > > Diff: https://reviewboard.asterisk.org/r/3410/diff/ > > > Testing > ------- > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
