Hello Jim, Jim Meyering <j...@meyering.net> writes:
> I was dismayed to discover this patch I wrote over three years ago. > Today I confirmed that the problem still remains by running these commands: > > git clone git://git.sv.gnu.org/hello.git \ > cd hello && ./bootstrap && ./configure && env make dist > > It failed like this: > > src/hello.c:27:10: fatal error: configmake.h: No such file or directory > #include "configmake.h" > ^~~~~~~~~~~~~~ > > Here's the patch I expect to push to master: > > From: Jim Meyering <meyer...@fb.com> > Date: Thu, 20 Mar 2014 12:31:32 -0700 > Subject: [PATCH] "make dist" did not depend on $(BUILT_SOURCES) > > * lib/am/distdir.am (distdir-am): New intermediate target. > Interpose this target between $(distdir) and its dependency > on $(DISTFILES), so that we can ensure $(BUILT_SOURCES) are > all created before we begin creating $(DISTFILES). > * t/dist-vs-built-sources.sh: Test for this. > * t/list-of-tests.mk (handwritten_TESTS): Add it. > * NEWS (Bugs fixed): Mention it. > Assaf Gordon reported that "make dist" (after ./configure > from a pristine clone of GNU hello) would fail due to the > absence of configmake.h while compiling lib/localcharset.c. > https://lists.gnu.org/r/bug-hello/2014-03/msg00016.html > --- > NEWS | 3 +++ > lib/am/distdir.am | 7 ++++-- > t/dist-vs-built-sources.sh | 56 > ++++++++++++++++++++++++++++++++++++++++++++++ > t/list-of-tests.mk | 1 + > 4 files changed, 65 insertions(+), 2 deletions(-) > create mode 100644 t/dist-vs-built-sources.sh OK to push. Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37