On 05/07/2012 12:46 AM, Jim Meyering wrote:
+
+  /* stat.st_size is valid only for regular files.  For others, use 0.  */
+  file_size = S_ISREG (stat_buf.st_mode) ? stat_buf.st_size : 0;

Is it right to use 0 there, for non-regular files?
Won't later code compute incorrect sizes in that case?

Also, as a nit, stat.st_size is also valid for
SHM and TMO files (this was in the patch I just sent).



Reply via email to