>>>>> Thomas Schwinge <tho...@codesourcery.com> writes: >>>>> On Tue, 27 Nov 2012 16:36:24 +0700, Ivan Shmakov wrote:
[…] >> Here, a diff line could've been saved by adding an opening { to the >> if above. (IOW, no need to drop the C grouping construct from >> here.) > Generally you're right with your suggestions (especially so in > context of the GNU Coding Standards). However note that I'm just > importing this code from upstream Linux 2.0.40, and when doing such > merges, the goal (usually) is to diverge from the upstream code as > little as possible (to ease future merge) — thus the "unusual" > formatting changes. ACK, thanks for the explanation. Frankly, I haven't expected for the things like trailing blanks, etc. to creep into the Linux source. -- FSF associate member #7257