On Wed, 10 Jan 2024 08:25:52 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:

>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTreeUI.java line 
>> 837:
>> 
>>> 835:             }
>>> 836:             else {
>>> 837:                 SynthGraphicsUtils.paintIcon(collapsedIcon, context, 
>>> g, x, y, w, h);
>> 
>> Guess it's a copy of `ExpandedIconWrapper `class, so `CollapsedIconWrapper 
>> `and `ExpandedIconWrapper` can be optimised to use common method passing in 
>> the "icon" argument..
>
> Should I merge the two classes into one class like instead of separate 
> `ExpandedIconWrapper` and `CollapsedIconWrapper`, only one `IconWrapper` 
> class?

guess you could since they are all private..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17294#discussion_r1447064941

Reply via email to