Bernhard Voelker wrote: > On 09/21/2012 12:36 PM, Jim Meyering wrote: >> Bernhard Voelker wrote: >>> On 09/21/2012 12:15 PM, Jim Meyering wrote: >>>> Bernhard Voelker wrote: >>>> If you merely "git add" your new test script, that should be enough, >>>> since that test compares the list of VC'd files under tests/ >>>> and the list of test file names. >>>> >>>> In other words, afaik, there is no problem. >>> >>> Right, but don't we need to add new tests to >>> tests/local.mk (all_tests) anymore? >> >> Not sure I understand the question, but I've just confirmed two things: >> >> if you git-add *and commit* (contrary to what I said above you do need >> to commit locally) a new tests/somewhere/*.sh (or .pl) file, but forget >> to list it in all_tests, then "make sc_tests_list_consistency" will >> point out the failure. > > That was exactly my question: > there's currently no way of having a syntax-check passed _before_ you > do the actual commit. I don't feel much comfortable with that: I used > to use syntax-check to assure that all I'm planning to commit is okay, > but now, this can only be assured afterwards.
Don't worry about that. "git commit" is a purely local operation. To the contrary, I've encourage many people to "git commit" more often than they are used to with other pre-dVCS tools. If you don't like a commit, you can always amend, split, merge them or remove one altogether (all before pushing, of course).
