Graham Barr <[EMAIL PROTECTED]> writes:

> On Sep 2, 2008, at 4:09 PM, David Golden wrote:
> 
> > On Tue, Sep 2, 2008 at 3:53 PM, Graham Barr <[EMAIL PROTECTED]> wrote:
> >>>  exit if $ENV{AUTOMATED_TESTING};
> >>
> >> Which removed the usefulness of those that do testing correctly and
> >> submit
> >> useful reports
> >
> > My point was that authors can opt-out if "keeping up" is too annoying.
> > I would hope that authors that want the benefits of CPAN Testers
> > would be willing to put a tiny bit of extra effort in.
> 
> Actually CPAN testers has been getting so annoying not useful recent,
> I am inclined to add that one line
> 
> > Remember -- this whole thread started with "why exit 0?"  Is that
> > really too much to ask an author with particularly unusual
> > requirements to learn and use?
> 
> Yes. The normal thing for any application is to exit non-zero when
> there is an error.
> 
> An error during Makefile.PL or Build.PL is not necessarily an error
> with the distribution. Calling die because of some system dependence
> is perfectly valid thing todo.
> 
> If Makefile.PL start returning zero, when they really failed, then
> anyone writing their own scripts can no longer depend on exit status
> to determine if things went well and have to start probing for the
> existence of file. That is just wrong.
> 
> Why should an error, which may not be related to the distribution, be
> reported as a FAIL ?
> 
> Why does cpan testers have to ask authors to do non standard things
> just to play nice with them ?

Because in this installation/testing phase there can be at least the
results PASS, FAIL, and NA (I am not sure if UNKNOWN can happen here).
Unfortunately the build script can only return a non-zero or zero exit
status. There's no protocol about the remaining values (1-255) to
differentiate the status.

Think of the exit status as a flag whether a FAIL report should be
sent or not.

Regards,
    Slaven

-- 
Slaven Rezic - slaven <at> rezic <dot> de

    tkrevdiff - graphical display of diffs between revisions (RCS, CVS or SVN)
    http://ptktools.sourceforge.net/#tkrevdiff

Reply via email to