It's really not _that_ bad - I think the comment predates other changes. These are basically the things that would be nice to clean up:
- Rendering documentation dynamically written as RedCloth templates is an unusual pattern - perhaps unique. I'd like to bring this in line with the mainstream, perhaps by compiling documentation to static HTML. I'm not worried about the performance piece - caches_page should take care of that. It's just an odd pattern. - There are things in those if-switches that seem better handled with routes. - I don't understand the middle if-switch - it seems to exist only to dodge the :layout key used in the final switch. Given those relatively minor quibbles, perhaps we should just remove the comment and focus on other areas. But if you have any ideas for improving the way documentation is handled please give it a go. Cheers, Brian On Sun, May 8, 2011 at 4:14 PM, Sudhindra Rao <[email protected]> wrote: > Hey Brian > So it says here > > "class DocumentationController < ApplicationController > caches_page :get > > # TODO Fix this. Fix it hard. > " > > Do you know what needs to be fixed hard .. I see a number of ifs. Is that > what is bothersome. > I am just trying to make some changes to slowly understand the codebase and > thought would play with code lightly.. > > -Sudhindra > > On 5/7/11 6:44 PM, Brian Guthrie wrote: >> >> Thanks Sudhindra. Much appreciated. :) >> >> On Sun, May 8, 2011 at 9:03 AM, Sudhindra Rao<[email protected]> >> wrote: >>> >>> Hi Brian, >>> >>> I think this is the highest priority and something that is a big hurdle >>> in >>> using cruisecontrol.rb. >>> >>> "Add support for performing push-button deploys" - we've faked this >>> on projects in the past. >>> >>> and the second priority would be the dashboard - for me personally. >>> >>> >>> I would like to work on the push-button deploys - once I understand all >>> the >>> changes that you have made recently. >>> >>> -Sudhindra >>> >>> _______________________________________________ >>> Cruisecontrolrb-developers mailing list >>> [email protected] >>> http://rubyforge.org/mailman/listinfo/cruisecontrolrb-developers >>> > > _______________________________________________ > Cruisecontrolrb-developers mailing list > [email protected] > http://rubyforge.org/mailman/listinfo/cruisecontrolrb-developers > _______________________________________________ Cruisecontrolrb-developers mailing list [email protected] http://rubyforge.org/mailman/listinfo/cruisecontrolrb-developers
