I think those "project not specified" checks can be eliminated - shouldn't routes take care of that?
On Sun, May 8, 2011 at 4:18 PM, Sudhindra Rao <[email protected]> wrote: > Brian, > Also there is > > render :text => 'Project not specified', :status => 404 and return unless > params[:project] > > > like duplication all over buildscontroller. Is that deemed to be low hanging > fruit. I think the code is confusing because of such proliferation. What > say? > > (I am not being to be a code critique but trying to figure out what is our > focus area.) > > -Sudhindra > > On 5/7/11 6:44 PM, Brian Guthrie wrote: >> >> Thanks Sudhindra. Much appreciated. :) >> >> On Sun, May 8, 2011 at 9:03 AM, Sudhindra Rao<[email protected]> >> wrote: >>> >>> Hi Brian, >>> >>> I think this is the highest priority and something that is a big hurdle >>> in >>> using cruisecontrol.rb. >>> >>> "Add support for performing push-button deploys" - we've faked this >>> on projects in the past. >>> >>> and the second priority would be the dashboard - for me personally. >>> >>> >>> I would like to work on the push-button deploys - once I understand all >>> the >>> changes that you have made recently. >>> >>> -Sudhindra >>> >>> _______________________________________________ >>> Cruisecontrolrb-developers mailing list >>> [email protected] >>> http://rubyforge.org/mailman/listinfo/cruisecontrolrb-developers >>> > > _______________________________________________ > Cruisecontrolrb-developers mailing list > [email protected] > http://rubyforge.org/mailman/listinfo/cruisecontrolrb-developers > _______________________________________________ Cruisecontrolrb-developers mailing list [email protected] http://rubyforge.org/mailman/listinfo/cruisecontrolrb-developers
