Your message dated Mon, 29 Apr 2024 12:22:46 +0000
with message-id <e1s1q1u-004bks...@fasolo.debian.org>
and subject line Bug#1068789: fixed in nsis 3.10-2
has caused the Debian Bug report #1068789,
regarding nsis: build fails if version number has buildX or ubuntuX suffix
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1068789: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1068789
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: nsis
Version: build fails if version number has buildX or ubuntuX suffix
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
X-Debbugs-Cc: michael.hud...@ubuntu.com

Dear Maintainer,

In Ubuntu we don't do binNMUs, we build sourceful changes with buildX
appended to the version number. This breaks with the current code in
d/rules which passes the whole version number to scons.

The attached patch is not very clean but it does fix the build for me:

  * d/rules: strip off ubuntuX, buildX from package version before feeding it
    to scons as VERSION.

Thanks for considering it!

Cheers,
mwh

-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-27-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_NZ.UTF-8:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru nsis-3.09/debian/control nsis-3.09/debian/control
--- nsis-3.09/debian/control    2024-04-01 20:02:28.000000000 +1300
+++ nsis-3.09/debian/control    2024-04-11 14:22:37.000000000 +1200
@@ -1,6 +1,5 @@
 Source: nsis
-Maintainer: Ubuntu Developers <ubuntu-devel-disc...@lists.ubuntu.com>
-XSBC-Original-Maintainer: Thomas Gaugler <tho...@dadie.net>
+Maintainer: Thomas Gaugler <tho...@dadie.net>
 Section: devel
 Priority: optional
 Build-Depends: docbook-xsl-ns,
diff -Nru nsis-3.09/debian/rules nsis-3.09/debian/rules
--- nsis-3.09/debian/rules      2024-03-02 21:11:24.000000000 +1300
+++ nsis-3.09/debian/rules      2024-04-11 14:22:12.000000000 +1200
@@ -11,7 +11,8 @@
 # Enable hardening
 export DEB_BUILD_MAINT_OPTIONS=hardening=+all
 
-VERSION=$(DEB_VERSION)
+VERSION=$(shell echo $(DEB_VERSION) | sed -Ee s/\(build\|ubuntu\)[0-9]+//)
+
 PREFIX=/usr
 DATADIR=$(PREFIX)/share/nsis
 DOCDIR=$(PREFIX)/share/doc/nsis

--- End Message ---
--- Begin Message ---
Source: nsis
Source-Version: 3.10-2
Done: Thomas Gaugler <tho...@dadie.net>

We believe that the bug you reported is fixed in the latest version of
nsis, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1068...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Gaugler <tho...@dadie.net> (supplier of updated nsis package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 29 Apr 2024 14:07:21 +0200
Source: nsis
Architecture: source
Version: 3.10-2
Distribution: unstable
Urgency: medium
Maintainer: Thomas Gaugler <tho...@dadie.net>
Changed-By: Thomas Gaugler <tho...@dadie.net>
Closes: 1068789
Changes:
 nsis (3.10-2) unstable; urgency=medium
 .
   * Bump Standards-Version to 4.7.0 (no changes needed)
   * Exclude revision suffix of Debian derivatives from VER_REVISION
     (Closes: #1068789)
Checksums-Sha1:
 ff39f13adfb04e92019b530c3e3deca106f3f756 1633 nsis_3.10-2.dsc
 a34dac67a122a39ef1a011325aacfe6858b5da81 25932 nsis_3.10-2.debian.tar.xz
Checksums-Sha256:
 6f7d5bd07423e0c533bb98e1ec2f039c335b1eacef080707525014ea0d2eaff5 1633 
nsis_3.10-2.dsc
 728f7b23eac14b397cc12bdb017e6b1806f1eac55612e9adc02480057d4df596 25932 
nsis_3.10-2.debian.tar.xz
Files:
 c141dc7c63357e15c3e42b29ac7e186a 1633 devel optional nsis_3.10-2.dsc
 ead5ced6d821c77c64b893187e42272c 25932 devel optional nsis_3.10-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQTjpQ0b6NokWkvBQbzqgwvGpoTNfAUCZi+N6wAKCRDqgwvGpoTN
fOmDAP9JGaZjjmltjhyBFmVwoeVuwro7t0eE48lUKDy8lwNXYQD+IeFyj5k72/5H
d1z2Him2s5uwqQxw7ZGeR30boRm/GAw=
=t4nH
-----END PGP SIGNATURE-----

Attachment: pgp2ewAJeT6T8.pgp
Description: PGP signature


--- End Message ---

Reply via email to