Your message dated Mon, 24 Aug 2009 13:03:11 +0200
with message-id <4a92736f.7010...@debian.org>
and subject line Re: Bug#528374: #528374 standout macro returns unsigned value
has caused the Debian Bug report #528374,
regarding standout macro returns unsigned value
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
528374: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=528374
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libncurses5-dev
Version: 5.7+20090510-1
Tags: patch
The standout macro expands to
(((stdscr)->_attrs = (((1UL) << ((8) + 8)))))
If this is compared against ERR, which expands to (-1), and GCC's
-Wsign-compare option is enabled, GCC displays the following warning (or
error, if -Werror is turned on):
comparison between signed and unsigned
The attached patch fixes this by casting the macro's result to int.
--
Matt http://ftbfs.org/
diff -ru ncurses-5.7+20090510~/include/curses.h.in
ncurses-5.7+20090510/include/curses.h.in
--- ncurses-5.7+20090510~/include/curses.h.in 2009-05-12 06:28:10.000000000
-0700
+++ ncurses-5.7+20090510/include/curses.h.in 2009-05-12 06:29:46.000000000
-0700
@@ -1093,9 +1093,9 @@
#if !NCURSES_OPAQUE
#if defined(_XOPEN_SOURCE_EXTENDED) && @NCURSES_EXT_COLORS@
#define wattrset(win,at) ((win)->_color = PAIR_NUMBER(at), \
- (win)->_attrs = (at))
+ ((int)(win)->_attrs = (at))
#else
-#define wattrset(win,at) ((win)->_attrs = (at))
+#define wattrset(win,at) ((int)((win)->_attrs = (at)))
#endif
#endif /* NCURSES_OPAQUE */
--- End Message ---
--- Begin Message ---
Version: 5.7+20090516-1
Thomas Dickey wrote:
> This was addressed in ncurses' 20090516 patch.
closing then, thanks.
--
Address: Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email: daniel.baum...@panthera-systems.net
Internet: http://people.panthera-systems.net/~daniel-baumann/
--- End Message ---
